Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resolution for entities package #66

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Jan 22, 2025

Fixes rancher/dashboard#13175

Add resolution for entities package so that it satisfies the constraints verified with the update of Rancher Dashboard to VueJS 3.5 on rancher/dashboard#13085 as we can't fix this on the shell side for now because of a bug in yarn classic.

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 9b3475b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
observability Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@owanturist owanturist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aalves08

Thank you for the proactive contribution to our codebase 🙇

The changes are fine by me, but I'd ask you to add changeset by following the link so I can approve the PR. Otherwise, if my commit is the last in the PR, I cannot approve it. Feel free to modify the content but keep in mind the file body will go to the release notes.

@aalves08
Copy link
Contributor Author

Done @owanturist 🙏

@aalves08 aalves08 requested a review from owanturist January 22, 2025 13:14
Copy link
Collaborator

@owanturist owanturist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@owanturist owanturist merged commit 0f190a2 into StackVista:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update resolutions in extensions (capi, observability and harvester) + release docs update
2 participants